feat: keep GatewayClass on uninstall via helm.sh/resource-policy when it's the default#1283
Merged
Merged
Conversation
Istiak2019331114
marked this pull request as draft
June 24, 2026 13:45
Istiak2019331114
force-pushed
the
fix/gatewayclass-finalizer-cleanup
branch
from
June 24, 2026 13:51
50da14f to
35f3b3a
Compare
Istiak2019331114
changed the title
Istiak2019331114
marked this pull request as ready for review
June 25, 2026 10:52
ArnobKumarSaha
requested changes
Jun 25, 2026
ArnobKumarSaha
left a comment
ArnobKumarSaha
left a comment
Member
There was a problem hiding this comment.
api change
helpers.tpl change
ArnobKumarSaha
force-pushed
the
fix/gatewayclass-finalizer-cleanup
branch
from
June 25, 2026 16:10
5cfe8f3 to
7aaaa79
Compare
ArnobKumarSaha
requested changes
Jun 25, 2026
ArnobKumarSaha
requested changes
Jun 26, 2026
Signed-off-by: Md. Istiak <mdistiak@appscode.com>
Signed-off-by: Md. Istiak <mdistiak@appscode.com>
Signed-off-by: Md. Istiak <mdistiak@appscode.com>
Signed-off-by: Md. Istiak <mdistiak@appscode.com>
Signed-off-by: Md. Istiak <mdistiak@appscode.com>
Signed-off-by: Arnob kumar saha <arnob@appscode.com>
ArnobKumarSaha
force-pushed
the
fix/gatewayclass-finalizer-cleanup
branch
from
June 26, 2026 12:53
9ab8e7e to
17a13b0
Compare
Member
|
Lets just use |
… it's the default Signed-off-by: Md. Istiak <mdistiak@appscode.com>
Istiak2019331114
force-pushed
the
fix/gatewayclass-finalizer-cleanup
branch
from
June 29, 2026 06:01
f2bf8a3 to
20e0b96
Compare
Istiak2019331114
changed the title
ArnobKumarSaha
requested changes
Jun 29, 2026
Member
|
{{- if eq (dig "catalog.appscode.com/is-default-gatewayclass" "" (.Values.gatewayClass.annotations | default dict)) "true" }} |
ArnobKumarSaha
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When uninstalling the service-gateway chart, the GatewayClass gets stuck in Terminating because the envoy-gateway controller adds gateway-exists-finalizer.gateway.networking.k8s.io and shuts down before removing it.
Solution
Use helm.sh/resource-policy: keep on the GatewayClass when catalog.appscode.com/is-default-gatewayclass: "true" is set. Helm preserves the resource instead of deleting it, avoiding the Terminating state entirely — no finalizer race condition.
Changes